Return-Path: 
 <dev-return-89030-apmail-lucene-dev-archive=lucene.apache.org@lucene.apache.org>
X-Original-To: apmail-lucene-dev-archive@www.apache.org
Delivered-To: apmail-lucene-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id A83B595DA
	for <apmail-lucene-dev-archive@www.apache.org>;
 Sun, 12 Feb 2012 09:15:43 +0000 (UTC)
Received: (qmail 81196 invoked by uid 500); 12 Feb 2012 09:15:41 -0000
Delivered-To: apmail-lucene-dev-archive@lucene.apache.org
Received: (qmail 79696 invoked by uid 500); 12 Feb 2012 09:15:29 -0000
Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@lucene.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@lucene.apache.org>
List-Post: <mailto:dev@lucene.apache.org>
List-Id: <dev.lucene.apache.org>
Reply-To: dev@lucene.apache.org
Delivered-To: mailing list dev@lucene.apache.org
Received: (qmail 79668 invoked by uid 99); 12 Feb 2012 09:15:26 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Feb 2012 09:15:26 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Feb 2012 09:15:25 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 36AE61B2A2D
	for <dev@lucene.apache.org>; Sun, 12 Feb 2012 09:15:05 +0000 (UTC)
Date: Sun, 12 Feb 2012 09:15:05 +0000 (UTC)
From: "Dawid Weiss (Commented) (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <924549573.29282.1329038105225.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1740524665.28766.1329000779470.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (LUCENE-3774) check-legal isn't doing its job
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206378#comment-13206378 ] 

Dawid Weiss commented on LUCENE-3774:
-------------------------------------

I looked at DependencyChecker, we should rewrite it as an ANT task, really -- it would be cleaner to use (with a dirset or a fileset). I'm thinking it could look like this:
{code}
<check-license>
 <jars>
  <fileset dir="base" includes="**/lib/*.jar" />
 </jars>
</check-license>
{code}
Base JAR names could be considered a match (or better, a mapper could be added to specify explicit mapping between the two). The upside of this is that we could have a single top-level check license task that would simply scan everything, once and wouldn't need to be updated as libs are added or removed.

I can help with the implementation, this is a trivial task, but I'd appreciate if you could hook it in ANT scripts where appropriate, Steve. Let me know if this is a good idea.


                
> check-legal isn't doing its job
> -------------------------------
>
>                 Key: LUCENE-3774
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3774
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.6, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>         Attachments: LUCENE-3774.patch, LUCENE-3774.patch
>
>
> In trunk, the {{check-legal-lucene}} ant target is not checking any {{lucene/contrib/\*\*/lib/}} directories; the {{modules/**/lib/}} directories are not being checked; and {{check-legal-solr}} can't be checking {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files in there that don't have a license.
> These targets are set up to take in a full list of {{lib/}} directories in which to check, but modules move around, and these lists are not being kept up-to-date.
> Instead, {{check-legal-\*}} should run for each module, if the module has a {{lib/}} directory, and it should be specialized for modules that have more than one ({{solr/core/}}) or that have a {{lib/}} directory in a non-standard place ({{lucene/core/}}).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org