Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Tue, 7 Feb 2012 18:24:59 +0000 (UTC)
From: "Uwe Schindler (Updated) (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <258172036.9418.1328639099833.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <406129087.9409.1328638979405.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (LUCENE-3757) Change AtomicReaderContext.leaves()
 to return itsself as only leave to simplify code and remove an otherwise
 unneeded ReaderUtil method
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/LUCENE-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uwe Schindler updated LUCENE-3757:
----------------------------------

    Attachment: LUCENE-3757.patch

Simple patch.

The only small issue is, that the "leaf" of this context also returns itsself, which should not be an issue, as leaves() is never called recursively (in contrast to children()).
                
> Change AtomicReaderContext.leaves() to return itsself as only leave to simplify code and remove an otherwise unneeded ReaderUtil method
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3757
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3757
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-3757.patch
>
>
> The documentation of IndexReaderContext.leaves() states that it returns (for convenience) all leave nodes, if the context is top-level (directly got from IndexReader), otherwise returns null. This is not correct for AtomicReaderContext, where it returns null always.
> To make it consistent, the convenience method should simply return itsself as only leave for atomic contexts. This makes the utility method ReaderUtil.leaves() obsolete and simplifies code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org