Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Sun, 5 Feb 2012 23:57:59 +0000 (UTC)
From: "Uwe Schindler (Issue Comment Edited) (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <2001803665.432.1328486279123.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1771150561.11053.1328005570150.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (LUCENE-3736) ParallelReader is now
 atomic, add convenience methods to wrap CompositeReaders in either "slow
 atomic" or "fast composite" way
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198337#comment-13198337 ] 

Uwe Schindler edited comment on LUCENE-3736 at 2/5/12 11:56 PM:
----------------------------------------------------------------

Here just my cleanup work in ParallelReader, nothing new. It's as before, only "bugs" (missing open checks) fixed and code violations (synthetic accessors, final fields).

The next step will be to remove the add() methods, as IndexReaders should not be changed after create.

Will work more tomorrow.

The plan is:
- Move all subreaders to ctor (builder-like API. First build reader-set, then call build)
- Rename ParallelReader to ParallelAtomicReader
- Add a ParallelCompositeReader with same builder API, but taking any CompositeReader-set and checks them that they are aligned (docStarts identical). The subreaders are ParallelAtomicReaders.
                
      was (Author: thetaphi):
    Here just my cleanup work in ParallelReader, nothing new. It's as before, only "bugs" (missing open checks) fixed and code violations (synthetic accessors, final fields).

The next step will be to remove the add() methods, as IndexReaders should not be changed after create.

Will work more tomorrow.

The plan is:
- Move all subreaders to ctor (builder-like API. First build reader-set, then call build)
- Rename ParallelReader to AtomicParallelReader
- Add a CompositeParallelReader with same builder API, but taking any CompositeReader-set and checks them that they are aligned (docStarts identical). The subreaders are AtomicParallelReaders.
                  
> ParallelReader is now atomic, add convenience methods to wrap CompositeReaders in either "slow atomic" or "fast composite" way
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3736
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3736
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/index
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 4.0
>
>         Attachments: LUCENE-3736.patch, LUCENE-3736.patch
>
>
> ParallelReader is now atomic. We should add a sugar wrapper method to allow synchronized composite readers (with same segment sizes) to be aligned with MultiReaders or wrapped by Slow:
> - one ParallelReader with Slow wrapped parallel readers, they only need same maxDoc() (and deletions)
> - a MultiReader containing all sub-ParallelReaders. This needs CompositeReaders with same docStarts[]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org