Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 19E119CED for ; Thu, 2 Feb 2012 21:03:24 +0000 (UTC) Received: (qmail 30199 invoked by uid 500); 2 Feb 2012 21:03:22 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 29778 invoked by uid 500); 2 Feb 2012 21:03:21 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 29771 invoked by uid 99); 2 Feb 2012 21:03:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2012 21:03:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2012 21:03:19 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 63EB61893D6 for ; Thu, 2 Feb 2012 21:02:58 +0000 (UTC) Date: Thu, 2 Feb 2012 21:02:58 +0000 (UTC) From: "Michael McCandless (Commented) (JIRA)" To: dev@lucene.apache.org Message-ID: <1679055070.4695.1328216578410.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1378308499.4574.1328215136437.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LUCENE-3749) Similarity.java javadocs and simplifications for 4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199219#comment-13199219 ] Michael McCandless commented on LUCENE-3749: -------------------------------------------- +1 looks great! > Similarity.java javadocs and simplifications for 4.0 > ---------------------------------------------------- > > Key: LUCENE-3749 > URL: https://issues.apache.org/jira/browse/LUCENE-3749 > Project: Lucene - Java > Issue Type: Task > Affects Versions: 4.0 > Reporter: Robert Muir > Fix For: 4.0 > > Attachments: LUCENE-3749.patch > > > As part of adding additional scoring systems to lucene, we made a lower-level Similarity > and the existing stuff became e.g. TFIDFSimilarity which extends it. > However, I always feel bad about the complexity introduced here (though I do feel there > are some "excuses", that its a difficult challenge). > In order to try to mitigate this, we also exposed an easier API (SimilarityBase) on top of > it that makes some assumptions (and trades off some performance) to try to provide something > consumable for e.g. experiments. > Still, we can cleanup a few things with the low-level api: fix outdated documentation and > shoot for better/clearer naming etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org