Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Mon, 27 Feb 2012 10:31:49 +0000 (UTC)
From: =?utf-8?Q?Jan_H=C3=B8ydahl_=28Commented=29_=28JIRA=29?=
 <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <1369334831.22713.1330338709083.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1761222367.610.1298867016916.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (SOLR-2393) Clean up Double Metaphone code
 (PhoneticFilterFactory and DoubleMetaphoneFilter)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/SOLR-2393?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13217=
144#comment-13217144 ]=20

Jan H=C3=B8ydahl commented on SOLR-2393:
-----------------------------------

Hi, can you re-upload the patch with name SOLR-2393.patch ?
               =20
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphone=
Filter)
> -------------------------------------------------------------------------=
-------
>
>                 Key: SOLR-2393
>                 URL: https://issues.apache.org/jira/browse/SOLR-2393
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Bill Bell
>            Assignee: Jan H=C3=B8ydahl
>         Attachments: SOLR-2383.diff
>
>
> From Ryan McKinley to Jan H=C3=B8ydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira

       
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org