Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5E0AE9D55 for ; Sun, 12 Feb 2012 20:35:25 +0000 (UTC) Received: (qmail 66491 invoked by uid 500); 12 Feb 2012 20:35:23 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 66433 invoked by uid 500); 12 Feb 2012 20:35:23 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 66426 invoked by uid 99); 12 Feb 2012 20:35:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Feb 2012 20:35:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Feb 2012 20:35:20 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id C13331B278C for ; Sun, 12 Feb 2012 20:34:59 +0000 (UTC) Date: Sun, 12 Feb 2012 20:34:59 +0000 (UTC) From: "Uwe Schindler (Commented) (JIRA)" To: dev@lucene.apache.org Message-ID: <1199573131.29906.1329078899792.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1740524665.28766.1329000779470.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LUCENE-3774) check-legal isn't doing its job MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206511#comment-13206511 ] Uwe Schindler commented on LUCENE-3774: --------------------------------------- ANT 1.8 improved performance of , I think I read that in the bulletin. But what we have seen: Dawid's code is compatible with ANT 1.7, so we dont need to change minimum requirements. If its slower or not should not force us to upgrade. So build works, all fine. -1 to *require* ANT 1.8. > check-legal isn't doing its job > ------------------------------- > > Key: LUCENE-3774 > URL: https://issues.apache.org/jira/browse/LUCENE-3774 > Project: Lucene - Java > Issue Type: Improvement > Components: general/build > Affects Versions: 3.6, 4.0 > Reporter: Steven Rowe > Assignee: Steven Rowe > Attachments: LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch > > > In trunk, the {{check-legal-lucene}} ant target is not checking any {{lucene/contrib/\*\*/lib/}} directories; the {{modules/**/lib/}} directories are not being checked; and {{check-legal-solr}} can't be checking {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files in there that don't have a license. > These targets are set up to take in a full list of {{lib/}} directories in which to check, but modules move around, and these lists are not being kept up-to-date. > Instead, {{check-legal-\*}} should run for each module, if the module has a {{lib/}} directory, and it should be specialized for modules that have more than one ({{solr/core/}}) or that have a {{lib/}} directory in a non-standard place ({{lucene/core/}}). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org