Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0B9398CF for ; Wed, 1 Feb 2012 11:39:22 +0000 (UTC) Received: (qmail 83154 invoked by uid 500); 1 Feb 2012 11:39:21 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 83015 invoked by uid 500); 1 Feb 2012 11:39:20 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 83007 invoked by uid 99); 1 Feb 2012 11:39:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Feb 2012 11:39:20 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Feb 2012 11:39:19 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 1FFE3183225 for ; Wed, 1 Feb 2012 11:38:59 +0000 (UTC) Date: Wed, 1 Feb 2012 11:38:59 +0000 (UTC) From: "Uwe Schindler (Resolved) (JIRA)" To: dev@lucene.apache.org Message-ID: <1128784579.2301.1328096339132.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <932360678.11046.1328005210287.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Resolved] (LUCENE-3735) Fix PayloadProcessorProvider to no longer use Directory for lookup, instead AtomicReader MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LUCENE-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-3735. ----------------------------------- Resolution: Fixed Committed 3.x revision: 1239084 > Fix PayloadProcessorProvider to no longer use Directory for lookup, instead AtomicReader > ---------------------------------------------------------------------------------------- > > Key: LUCENE-3735 > URL: https://issues.apache.org/jira/browse/LUCENE-3735 > Project: Lucene - Java > Issue Type: Sub-task > Components: core/index > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Fix For: 3.6, 4.0 > > Attachments: LUCENE-3735-3x.patch, LUCENE-3735.patch, LUCENE-3735.patch > > > The PayloadProcessorProvider has a broken API, this should be fixed. The current trunk mimics the old behaviour, but not 100%. > The PayloadProcessorProvider API should return a PayloadProcessor based on the AtomicReader instance that gets merged. As AtomicReader do no longer know the directory they are reside (they could be e.g. FilterIndexReaders, MemoryIndexes,...) a selection by Directory is no longer possible. > The current code in Lucene trunk mimics the old behavior by doing an instanceof SegmentReader check and then asking for a DirProvider. If something else is merged in, Payload processing is not supported. This should be changed, the old API could be kept backwards compatible by moving the instanceof check in a "convenience class" DirPayloadProcessorProvider, extending PayloadProcessorProvider. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org