Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B10359213 for ; Fri, 3 Feb 2012 18:48:22 +0000 (UTC) Received: (qmail 22420 invoked by uid 500); 3 Feb 2012 18:48:21 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 22002 invoked by uid 500); 3 Feb 2012 18:48:20 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 21994 invoked by uid 99); 3 Feb 2012 18:48:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Feb 2012 18:48:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Feb 2012 18:48:18 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 9DA6818B970 for ; Fri, 3 Feb 2012 18:47:58 +0000 (UTC) Date: Fri, 3 Feb 2012 18:47:58 +0000 (UTC) From: "Hoss Man (Commented) (JIRA)" To: dev@lucene.apache.org Message-ID: <1122414083.8449.1328294878647.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <395397940.7541.1328280836576.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (SOLR-3093) Remove unused features and MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SOLR-3093?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13199= 930#comment-13199930 ]=20 Hoss Man commented on SOLR-3093: -------------------------------- I think yonik's point is that unlike things in SOLR-1052 where existing use= rs would have a reasonable expectation that the syntax would definitively d= o something (ie: use specific classes/settings), the config in this issue w= as _always_ just an optimization hint, and the system ultimately works fine= even if/when it is ignored. Personally i think that in these cases, it would be sufficient to WARN that= these optimization hints are no longer used and being ignored so people ca= n clean up if/when they want, but since they don't *have* to change anythin= g to have a working solr instance (that still externally behaves the way it= would in older versions of solr) there's no reason to FAIL and annoy them. =20 > Remove unused features and > --------------------------------------------------------------- > > Key: SOLR-3093 > URL: https://issues.apache.org/jira/browse/SOLR-3093 > Project: Solr > Issue Type: Improvement > Reporter: Jan H=C3=B8ydahl > Fix For: 3.6, 4.0 > > > SolrConfig.java still tries to parse > But the only user of this param was SolrIndexSearcher.java line 366-381 w= hich is commented out. > Probably the whole logic should be ripped out, and we fail hard if we fin= d this config option in solrconfig.xml > Also, the config option is old and no longer used or needed?= There is some code which tries to use it but I believe that since 1.4 ther= e are more efficient ways to do the same. Should we also fail-fast if found= in config or only print a warning? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org