lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik Hatcher (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3040) Avoid use of qt param for the DIH in the admin UI
Date Thu, 23 Feb 2012 10:29:48 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214530#comment-13214530
] 

Erik Hatcher commented on SOLR-3040:
------------------------------------

+0 - just be sure to call out a sufficient CHANGES entry that mentions that non-/-prefixed
DIH handlers will need to be changed.  And maybe only do this change on 4.x rather than 3.x
since it is kind of an unnecessary break.

Don't get me wrong, I'm all for getting Solr to handle path-based request handlers without
qt - I'd rather *all* request handlers be path-based personally (even if I'm the one that
committed qt=/rh to work, as this was for consistency on the client-side) and to get rid of
qt fully (but that's a separate issue).
                
> Avoid use of qt param for the DIH in the admin UI
> -------------------------------------------------
>
>                 Key: SOLR-3040
>                 URL: https://issues.apache.org/jira/browse/SOLR-3040
>             Project: Solr
>          Issue Type: Improvement
>          Components: web gui
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: SOLR-3040_avoid_qt_for_DIH_in_admin_ui.patch
>
>
> I really, really dislike that the qt parameter can used to refer to request handlers
starting with a '/', _especially_ for non-search handlers.  The admin UI has one place I am
aware of that attempts to do this, which is the DIH's admin page.  Since we have two UIs in
trunk, the new and old, there are actually two UIs where this occurs, and the old UI has two
related files that need updating, in order to address this issue.
> An example URL generated by the UI today is this:
>   http://localhost:8983/solr/rss/select?qt=/dataimport&command=show-config
> And here it is without using qt:
>   http://localhost:8983/solr/rss/dataimport?command=show-config
> I do realize that fixing this issue as I do in my patch will make the UI not work if
the DIH isn't registered with a leading '/', but honestly I wonder who if anyone out there
does that.  And even then, it's easily rectified.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message