lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-1233) Remove restriction that /select cannot be used for /-prefixed request handlers via qt
Date Fri, 24 Feb 2012 18:51:49 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215810#comment-13215810
] 

David Smiley commented on SOLR-1233:
------------------------------------

I'm very surprised that I am the only one commenting on this issue. FWIW, in other private
communication channels, I know there is support for what I want here among at least some committers.

I haven't yet looked at the code involved for suggestions here; I'm speaking based on how
I think things should work and not work, based on intuitiveness and security.  In general
I feel it is best practice to use '/' leading request handler names and not use "qt", but
I don't hate it enough when used in limited (search-only) circumstances to propose its demise.
 But if someone proposes its deprecation that then I am +1 for that.

Here is my proposal:
* Solr should error if the parameter "qt" is supplied with a leading '/'.  (trunk only)
* Solr should only honor "qt" if the target request handler extends solr.SearchHandler.
* The new admin UI should only use 'qt' when it has to. For the query screen, it could present
a little pop-up menu of handlers to choose from, including "/select?qt=mycustom" for handlers
that aren't named with a leading '/'.  This choice should be positioned at the top.

And before I forget, me or someone should investigate if there are any similar security problems
with the shards.qt parameter.  Perhaps shards.qt can abide by the same rules outlined above.

Does anyone foresee any problems with this proposal?

On a related subject, I think the notion of a default request handler is bad -- the default="true"
thing.  Honestly I'm not sure what it does, since I noticed Solr trunk redirects '/solr/'
to the new admin UI at '/solr/#/'.  Assuming it doesn't do anything useful anymore, I think
it would be clearer to use <requestHandler name="/select" class="solr.SearchHandler">
instead of what's there now.  The delta is to put the leading '/' on this request handler
name, and remove the "default" attribute.
                
> Remove restriction that /select cannot be used for /-prefixed request handlers via qt
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-1233
>                 URL: https://issues.apache.org/jira/browse/SOLR-1233
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Erik Hatcher
>            Assignee: Erik Hatcher
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-1233.patch
>
>
> Currently /select?qt=/whatever is blocked by SolrDispatchFilter.  It makes life a lot
easier to make general requests to any request handler (for example in SOLR-1230 where dataimport.jsp
needs to request to arbitrary handler names).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message