lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3774) check-legal isn't doing its job
Date Sun, 12 Feb 2012 13:48:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206415#comment-13206415
] 

Dawid Weiss commented on LUCENE-3774:
-------------------------------------

Sure there are pros and cons. I just tend to disagree with you about which solution is better.
Having a few top-level exclusion rules in the fileset (build folders, example folders) is
not that bad to me. Having it automatically detect missing files in modules and other locations
is a big plus that to me makes the decision easy. I just executed it from the top checkout
and it already got some inconsistencies:
{noformat}
[license-check] MISSING NOTICE for the license file:
[license-check]   C:\Work\lucene-solr\lucene\contrib\misc\ant_lib\cpptasks-LICENSE-ASL.txt
[license-check]   Expected location below:
[license-check]   C:\Work\lucene-solr\lucene\contrib\misc\ant_lib\cpptasks-NOTICE.txt

[there is only one shared notice for ant and ant-junit?]
[license-check] MISSING NOTICE for the license file:
[license-check]   C:\Work\lucene-solr\lucene\lib\ant-junit-LICENSE-ASL.txt
[license-check]   Expected location below:
[license-check]   C:\Work\lucene-solr\lucene\lib\ant-junit-NOTICE.txt
{noformat}

bq. It means we can easily add/disable modules without editing many 'global' files.

Since the detection is global this isn't an argument because any JAR you add will just be
included in the global detection. We can restrict its pattern to follow **/lib/** to simulate
previous behavior but as the above output shows (ant_lib) it may be wiser to just respond
to build failures resulting from inconsistencies as they arise?


                
> check-legal isn't doing its job
> -------------------------------
>
>                 Key: LUCENE-3774
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3774
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.6, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>         Attachments: LUCENE-3774.patch, LUCENE-3774.patch
>
>
> In trunk, the {{check-legal-lucene}} ant target is not checking any {{lucene/contrib/\*\*/lib/}}
directories; the {{modules/**/lib/}} directories are not being checked; and {{check-legal-solr}}
can't be checking {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files
in there that don't have a license.
> These targets are set up to take in a full list of {{lib/}} directories in which to check,
but modules move around, and these lists are not being kept up-to-date.
> Instead, {{check-legal-\*}} should run for each module, if the module has a {{lib/}}
directory, and it should be specialized for modules that have more than one ({{solr/core/}})
or that have a {{lib/}} directory in a non-standard place ({{lucene/core/}}).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message