lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-3141) Deprecate OPTIMIZE command in Solr
Date Mon, 20 Feb 2012 14:57:34 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211898#comment-13211898
] 

Jan Høydahl commented on SOLR-3141:
-----------------------------------

@Yonik, How would you feel about this approach instead:

* Add the new forceMerge feature, but instead of true/false, it takes N as number of segments,
i.e. &forceMerge=2. This adds value to Solr's API
* Keep the old &optimize=true API (equivalent to forceMerge=1), but let users control
in solrconfig.xml how an old optimize is interpreted. The option could look like (don't mind
the naming for now):
{code:xml}
<mainIndex>
 <oldOptimizeIsIntrepretedAs>noop|noopWithLogWarning|commit|softCommit|forceMerge=N</oldOptimizeIsIntrepretedAs>
</mainIndex>
{code}

Default could be "noopWithLogWarning", and nothing would happen on an attempted optimize,
except logging a warning in logs pointing people to some documentation. This will give people
three choices: A) Stop using optimize if they don't need it. Problem solved. B) If they wind
up really needing it, start using forceMerge=N instead. Problem solved or C) Change the config
param to whatever suits their situation the best, e.g. "forceMerge=1" would mimic old behaviour
but "commit" would cause a commit to happen on optimize, "noop" would do noop, but get rid
of log warnings etc. This would be for people who cannot or won't change their own code.
                
> Deprecate OPTIMIZE command in Solr
> ----------------------------------
>
>                 Key: SOLR-3141
>                 URL: https://issues.apache.org/jira/browse/SOLR-3141
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 3.5
>            Reporter: Jan Høydahl
>              Labels: force, optimize
>             Fix For: 3.6
>
>         Attachments: SOLR-3141.patch, SOLR-3141.patch
>
>
> Background: LUCENE-3454 renames optimize() as forceMerge(). Please read that issue first.
> Now that optimize() is rarely necessary anymore, and renamed in Lucene APIs, what should
be done with Solr's ancient optimize command?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message