lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (Reopened) (JIRA)" <j...@apache.org>
Subject [jira] [Reopened] (LUCENE-2604) add regexpquery to queryparser
Date Wed, 29 Feb 2012 03:58:19 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-2604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hoss Man reopened LUCENE-2604:
------------------------------


Re-opening ... some issues were pointed out in a recent mailing list thread that definitely
seem like they should be addressed before this is officially released...

* queryparsersyntax.xml doesn't mention this feature at all -- as major new syntax is should
really get it's own section with an example showing the syntax
* queryparsersyntax.xml's section on "Escaping Special Characters" needs to mention that '/'
is a special character
* QueryParser.escape needs to include '/' in the characters it escapes
** ditto for Solr's ClientUtils.escapeQueryChars and SolrPluginUtils.partialEscape
** i've got a patch for this i'll commit as soon as the tests finish.

Also: Given that Yury encountered some real world situations in which the new syntax caused
problems with existing queries, it seems like we should definitely make a note about this
possibility more promonient ... i'm not sure if it makes sense in MIGRATE.txt but at a minimum
it seems like the existing CHANGES.txt entry should mention it, maybe something like...

{noformat}
* LUCENE-2604: Added RegexpQuery support to QueryParser. Regular expressions
  are now directly supported by the standard queryparser using the syntax... 
     fieldName:/expression/ OR /expression against default field/
  Users who wish to search for literal "/" characters are advised to 
  backslash-escape or quote those characters as needed. 
  (Simon Willnauer, Robert Muir)
{noformat}

...thoughts?
                
> add regexpquery to queryparser
> ------------------------------
>
>                 Key: LUCENE-2604
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2604
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: core/queryparser
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-2604.patch, LUCENE-2604.patch, LUCENE-2604.patch
>
>
> patch that adds RegexpQuery if you /enter an expression between slashes like this/
> i didnt do the contrib ones but could add it there too if it seems like a good idea.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message