lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LUCENE-3756) Don't allow IndexWriterConfig setters to chain
Date Tue, 07 Feb 2012 16:00:59 GMT
Don't allow IndexWriterConfig setters to chain
----------------------------------------------

                 Key: LUCENE-3756
                 URL: https://issues.apache.org/jira/browse/LUCENE-3756
             Project: Lucene - Java
          Issue Type: Improvement
            Reporter: Michael McCandless
            Assignee: Michael McCandless


Spinoff from LUCENE-3736.

I don't like that IndexWriterConfig's setters are chainable; it
results in code in our tests like this:

{noformat}
IndexWriter writer = new IndexWriter(dir, newIndexWriterConfig( TEST_VERSION_CURRENT, new
MockAnalyzer(random)).setMaxBufferedDocs(2).setMergePolicy(newLogMergePolicy()));
{noformat}

I think in general we should avoid chaining since it encourages hard
to read code (code is already hard enough to read!).


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message