lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3743) LuceneTestCase's uncaught exceptions handler should check for AssumptionViolatedExceptions and then not trigger test failure
Date Wed, 01 Feb 2012 00:30:56 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197427#comment-13197427
] 

Steven Rowe commented on LUCENE-3743:
-------------------------------------

Robert and I were looking at https://builds.apache.org/job/Lucene-Solr-tests-only-3.x-java7/1685/testReport/junit/org.apache.lucene.analysis.charfilter/HTMLStripCharFilterTest/testRandom/
-- random data is generated that contains charcter U+FFFF, and tracking down all the locations
where that character is generated in all the random generators looked hard; Robert suggested
an Assume to ignore test data containing U+FFFF.

>From #lucene IRC:

{noformat}
  rmuir: maybe we should throw a junit assume or something
         so it doesnt fail
         but prevents you from wasting time 
sarowe1: makes sense
  rmuir: i think we can just 'throw new AssumptionViolatedException'
sarowe1: I'll give it a try
         didn't work for me - it stops the run the same as assert
[...]
sarowe1: LuceneTestCase should ignore the failure???
  rmuir: yeah
         i think it should treat it as assume?
         im not sure
         hmm assume from another thread...
         i think thats an LTC bug maybe
         because from a single thread it works:
[...]
  rmuir: we should fix that
{noformat}


                
> LuceneTestCase's uncaught exceptions handler should check for AssumptionViolatedExceptions
and then not trigger test failure
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3743
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3743
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/test
>    Affects Versions: 3.5, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Minor
>         Attachments: LUCENE-3743.patch
>
>
> As in single-threaded tests, {{LuceneTestCase}} should not trigger test failures for
{{AssumptionViolatedException}}'s when they occur in multi-threaded tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message