lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Koji Sekiguchi <k...@r.email.ne.jp>
Subject Re: PatternReplaceCharFilter, LUCENE-3820
Date Mon, 27 Feb 2012 00:20:43 GMT
(12/02/23 18:59), Dawid Weiss wrote:
> Heads up.
>
> https://issues.apache.org/jira/browse/LUCENE-3820
>
> I've suggested a patch to PatternReplaceCharFilter that heavily
> simplifies the code, passes tests that previously didn't pass and,
> well, perhaps contains the processing logic that is a bit easier to
> understand (for me :).
>
> This patch does drop support for block delimiters and block processing
> though (!) so the entire input from CharStreams underneath is buffered
> and preprocessed in one go. Is anybody using these block delimiters?
> It should be possible to add them back in, but if it's a dead feature
> then we may as well just drop it entirely.

Hi Dawid,

As I thought that buffering entire String tends to take place OOM when doing
pattern matching, I introduced an idea of the block. If it shouldn't,
I think we can just drop it.

koji
-- 
Query Log Visualizer for Apache Solr
http://soleami.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message