lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dodsworth (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3017) Allow edismax stopword filter factory implementation to be specified
Date Fri, 03 Feb 2012 22:00:51 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200085#comment-13200085
] 

Michael Dodsworth commented on SOLR-3017:
-----------------------------------------

That would certainly allow us to hack around the problem in a way that doesn't require a change
to the query parser (i.e., extending StopFilterFactory and overriding its create method to
return our own filter).

Are we concerned about breaking code that may be calling StopFilterFactory.create() and is
expecting a StopFilter (I wonder if there's a reason TokenStream wasn't used originally)?

Agreed on the inaccurate param name. I'll fix that up in the next patch.

Specifying the factory class name as a param *is* optional and, as you say, should be a rare
case.
If there's a better, more general fix for this, I'm happy to take that on.


                
> Allow edismax stopword filter factory implementation to be specified
> --------------------------------------------------------------------
>
>                 Key: SOLR-3017
>                 URL: https://issues.apache.org/jira/browse/SOLR-3017
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Michael Dodsworth
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: SOLR-3017-without-guava-alternative.patch, SOLR-3017.patch, SOLR-3017.patch,
edismax_stop_filter_factory.patch
>
>
> Currently, the edismax query parser assumes that stopword filtering is being done by
StopFilter: the removal of the stop filter is performed by looking for an instance of 'StopFilterFactory'
(hard-coded) within the associated field's analysis chain.
> We'd like to be able to use our own stop filters whilst keeping the edismax stopword
removal goodness. The supplied patch allows the stopword filter factory class to be supplied
as a param, "stopwordFilterClassName". If no value is given, the default (StopFilterFactory)
is used.
> Another option I looked into was to extend StopFilterFactory to create our own filter.
Unfortunately, StopFilterFactory's 'create' method returns StopFilter, not TokenStream. StopFilter
is also final.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message