lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangtai Liang (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3781) Another incomplete fix for the NPE bugs in ParallelReader.java
Date Tue, 14 Feb 2012 14:15:59 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guangtai Liang updated LUCENE-3781:
-----------------------------------

    Description: 
The fix revision 407851  was aimed to remove an NPE bug ("fix NPE and deletion bugs in ParallelReader:
LUCENE-561") on the value  of  "termDocs" in the methods "next", "read", "skipTo", "close"
of the file "/lucene/java/trunk/src/java/org/apache/lucene/index/ParallelReader.java
" , but it is incomplete. 
Since the value  "termDocs" could be null during the runtime execution, its value should also
be null-checked before being dereferenced in other methods. 

The buggy code locations the same fix needs to be applied at are as bellows: 
 
Line 574, 575 of the methods "doc()" , and "freq": 

 public int doc() { return termDocs.doc(); }
 public int freq() { return termDocs.freq(); }


  was:
The fix revision 407851  was aimed to remove an NPE bug (LUCENE-561) on the value  of  "termDocs"
in the methods "next", "read", "skipTo", "close" of the file "/lucene/java/trunk/src/java/org/apache/lucene/index/ParallelReader.java
" , but it is incomplete. 
Since the value  "termDocs" could be null during the runtime execution, its value should also
be null-checked before being dereferenced in other methods. 

The buggy code locations the same fix needs to be applied at are as bellows: 
 
Line 574, 575 of the methods "doc()" , and "freq": 

 public int doc() { return termDocs.doc(); }
 public int freq() { return termDocs.freq(); }


    
> Another incomplete fix for the NPE bugs in ParallelReader.java
> --------------------------------------------------------------
>
>                 Key: LUCENE-3781
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3781
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: core/index
>    Affects Versions: 3.0
>            Reporter: Guangtai Liang
>              Labels: incomplete_fix, missing_fixes
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The fix revision 407851  was aimed to remove an NPE bug ("fix NPE and deletion bugs in
ParallelReader: LUCENE-561") on the value  of  "termDocs" in the methods "next", "read", "skipTo",
"close" of the file "/lucene/java/trunk/src/java/org/apache/lucene/index/ParallelReader.java
> " , but it is incomplete. 
> Since the value  "termDocs" could be null during the runtime execution, its value should
also be null-checked before being dereferenced in other methods. 
> The buggy code locations the same fix needs to be applied at are as bellows: 
>  
> Line 574, 575 of the methods "doc()" , and "freq": 
>  public int doc() { return termDocs.doc(); }
>  public int freq() { return termDocs.freq(); }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message