lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (Closed) (JIRA)" <>
Subject [jira] [Closed] (SOLR-3040) Avoid use of qt param for the DIH in the admin UI
Date Fri, 24 Feb 2012 07:04:48 GMT


David Smiley closed SOLR-3040.

       Resolution: Fixed
    Fix Version/s: 4.0
         Assignee: David Smiley

Committed branch_3x: r1293105 trunk: r1293102

CHANGES.txt entry underneath upgrade instructions:
* SOLR-3040: The DIH's admin UI (dataimport.jsp) now requires
 DIH request handlers to start with a '/'. (dsmiley)

FYI it turned out that in the span of time since when I did the first patch and when I committed
now, the new admin UI already gained this limitation (leading '/' required).  Wether deliberate
or accidental, I'm glad.
> Avoid use of qt param for the DIH in the admin UI
> -------------------------------------------------
>                 Key: SOLR-3040
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: web gui
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 3.6, 4.0
>         Attachments: SOLR-3040_avoid_qt_for_DIH_in_admin_ui.patch
> I really, really dislike that the qt parameter can used to refer to request handlers
starting with a '/', _especially_ for non-search handlers.  The admin UI has one place I am
aware of that attempts to do this, which is the DIH's admin page.  Since we have two UIs in
trunk, the new and old, there are actually two UIs where this occurs, and the old UI has two
related files that need updating, in order to address this issue.
> An example URL generated by the UI today is this:
>   http://localhost:8983/solr/rss/select?qt=/dataimport&command=show-config
> And here it is without using qt:
>   http://localhost:8983/solr/rss/dataimport?command=show-config
> I do realize that fixing this issue as I do in my patch will make the UI not work if
the DIH isn't registered with a leading '/', but honestly I wonder who if anyone out there
does that.  And even then, it's easily rectified.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message