lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-3093) Remove unused features <boolTofilterOptimizer> and <HashDocSet>
Date Sat, 04 Feb 2012 00:03:53 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200177#comment-13200177
] 

Jan Høydahl commented on SOLR-3093:
-----------------------------------

@MarkMiller: Just to be suer... In [rev922957|http://svn.apache.org/viewvc?view=revision&revision=922957]
with commit message "a hackey commit of stuff needed to get on lucene 3.0.1" :) you commented
out the code in [SolrIndexSearcher|http://svn.apache.org/viewvc/lucene/solr/branches/solr/src/java/org/apache/solr/search/SolrIndexSearcher.java?r1=922957&r2=922956&pathrev=922957]
related to LuceneQueryOptimizer to get it to compile. Was that intended as a permanent removal
of the optimizer or did you plan to put it back? Do anyone *want* the optimizer back?
                
> Remove unused features <boolTofilterOptimizer> and <HashDocSet>
> ---------------------------------------------------------------
>
>                 Key: SOLR-3093
>                 URL: https://issues.apache.org/jira/browse/SOLR-3093
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Jan Høydahl
>             Fix For: 3.6, 4.0
>
>
> SolrConfig.java still tries to parse <boolTofilterOptimizer>
> But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented
out.
> Probably the whole logic should be ripped out, and we fail hard if we find this config
option in solrconfig.xml
> Also, the <HashDocSet> config option is old and no longer used or needed? There
is some code which tries to use it but I believe that since 1.4 there are more efficient ways
to do the same. Should we also fail-fast if found in config or only print a warning?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message