lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Dyer (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3033) "numberToKeep" on replication handler does not work with "backupAfter"
Date Wed, 01 Feb 2012 20:22:58 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198114#comment-13198114
] 

James Dyer commented on SOLR-3033:
----------------------------------

I agree we should have it as a request param for backwards compatibility, and allow it as
a better-named initParam.  Clear documentation in the wiki would be in order.  Two things
though:

1. Maybe we should have the request param override the init param rather than generate an
error.  This is consistent with how handler params work in general.  As it was lost on me,
many people won't appreciate the subtle difference between an init-param and a request-param
in this case and will just want it to behave like any other handler.  (moot point here if
we are just removing the init-param from 4.x and keeping it, deprecated, in 3.x)

2. Are you saying that we should require this param to be outside <slave/> and <master/>,
thus avoiding the conflict if a node is a repeater?  We could allow it inside <slave/>
and <master/> and document that in the case of a repeater the value in <slave/>
takes precedence over the value in <master/>.  This is more confusing for the repeater
case, but simpler in that it seems every other init parameter gets specified separately for
slaves and master.

Once again I don't have a strong preference here but the thoughts occurred...
                
> "numberToKeep" on replication handler does not work with "backupAfter"
> ----------------------------------------------------------------------
>
>                 Key: SOLR-3033
>                 URL: https://issues.apache.org/jira/browse/SOLR-3033
>             Project: Solr
>          Issue Type: Bug
>          Components: replication (java)
>    Affects Versions: 3.5
>         Environment: openjdk 1.6, linux 3.x
>            Reporter: Torsten Krah
>         Attachments: SOLR-3033.patch
>
>
> Configured my replication handler like this:
>    <requestHandler name="/replication" class="solr.ReplicationHandler" >
>        <lst name="master">
>        <str name="replicateAfter">startup</str>
>        <str name="replicateAfter">commit</str>
>        <str name="replicateAfter">optimize</str>
>        <str name="confFiles">elevate.xml,schema.xml,spellings.txt,stopwords.txt,stopwords_de.txt,stopwords_en.txt,synonyms_de.txt,synonyms.txt</str>
>        <str name="backupAfter">optimize</str>
>        <str name="numberToKeep">1</str>
>      </lst>
>    </requestHandler>
> So after optimize a snapshot should be taken, this works. But numberToKeep is ignored,
snapshots are increasing with each call to optimize and are kept forever. Seems this settings
have no effect.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message