lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (Commented) (JIRA)" <>
Subject [jira] [Commented] (SOLR-3076) Solr should support block joins
Date Wed, 08 Feb 2012 16:07:59 GMT


Michael McCandless commented on SOLR-3076:

bq. The only concern I have is that your patch makes BlockJoinQuery sources a little bit puzzling
from my POV

Well, that was the only way to "respect" the incoming acceptDocs, I think?  Ie, BJQ must test
itself against the acceptDocs.

Your patch is interesting (creating a DocIdSetBackwardIterator) but that looks like a more
invasive/larger change?  So far it's only BJQ and block grouping that need this "rewindability",
and requiring that the app provides a Filter producing a FixedBitSet for each segment (as
CachingWrapperFilter will do) is not too imposing... maybe if more queries/filters require
this we can rewindability to the interface... but I think it's too big a change at this point?
 Maybe open a new issue to explore it?

bq. Also, I don't know how much the problem we are talking about is relevant to Solr - it
looks like pretty Lucene issue. What should we do? Should we care?

You're right this is mostly a Lucene issue so far, but I think we can just use this same issue
number (I'll reference it in Lucene's changes), and then we can keep this issue open for fixing
the solr side (to be able to index doc blocks, and then add BJQ query search-time support).

> Solr should support block joins
> -------------------------------
>                 Key: SOLR-3076
>                 URL:
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Grant Ingersoll
>         Attachments: SOLR-3076.patch, bjq-vs-filters-backward-disi.patch, bjq-vs-filters-illegal-state.patch
> Lucene has the ability to do block joins, we should add it to Solr.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message