lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (Commented) (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-3093) Remove unused features <boolTofilterOptimizer> and <HashDocSet>
Date Fri, 03 Feb 2012 15:55:53 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199789#comment-13199789
] 

Jan Høydahl commented on SOLR-3093:
-----------------------------------

Is there any use at all in the <HashDocSet> config any more? Should code related to
this also be removed?

I agree with Tommaso that fail fast is better, not to fool <=1.3 users who modify their
old schema to believe that these settings have any effect at all, see discussion in SOLR-1052.
                
> Remove unused features <boolTofilterOptimizer> and <HashDocSet>
> ---------------------------------------------------------------
>
>                 Key: SOLR-3093
>                 URL: https://issues.apache.org/jira/browse/SOLR-3093
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Jan Høydahl
>             Fix For: 3.6, 4.0
>
>
> SolrConfig.java still tries to parse <boolTofilterOptimizer>
> But the only user of this param was SolrIndexSearcher.java line 366-381 which is commented
out.
> Probably the whole logic should be ripped out, and we fail hard if we find this config
option in solrconfig.xml
> Also, the <HashDocSet> config option is old and no longer used or needed? There
is some code which tries to use it but I believe that since 1.4 there are more efficient ways
to do the same. Should we also fail-fast if found in config or only print a warning?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message