lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3141) Deprecate OPTIMIZE command in Solr
Date Mon, 20 Feb 2012 14:02:38 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211849#comment-13211849
] 

Yonik Seeley commented on SOLR-3141:
------------------------------------

bq. The compensation is that they are forced to again look at that code an then they think
about removing the call alltogether.

The proposal simply breaks existing systems (on purpose) on upgrade with no offsetting gain
in functionality, just because we believe some people have made the wrong tradeoff in their
app.  This is not the right solution.

We see people making what we believe to be the wrong tradeoffs all the time in Solr.  One
example is optimizing for query performance by pumping up cache sizes to insane levels, pumping
up the heap to compensate, and then being plagued with long GC times.  The answer is not to
second guess everyone and break existing configurations.  People will continue to make mistakes
like this, and even if optimize was changed to forceMerge, you can be assured that some people
will still make the wrong trade-off in the future using the new name.

I've thought about this for a while now... please consider this my formal veto to this change.

                
> Deprecate OPTIMIZE command in Solr
> ----------------------------------
>
>                 Key: SOLR-3141
>                 URL: https://issues.apache.org/jira/browse/SOLR-3141
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 3.5
>            Reporter: Jan H√łydahl
>              Labels: force, optimize
>             Fix For: 3.6
>
>         Attachments: SOLR-3141.patch, SOLR-3141.patch
>
>
> Background: LUCENE-3454 renames optimize() as forceMerge(). Please read that issue first.
> Now that optimize() is rarely necessary anymore, and renamed in Lucene APIs, what should
be done with Solr's ancient optimize command?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message