lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Rowe (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3774) check-legal isn't doing its job
Date Mon, 13 Feb 2012 13:46:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206875#comment-13206875
] 

Steven Rowe commented on LUCENE-3774:
-------------------------------------

bq. I assumed modules doesn't need to be self-contained like Lucene or Solr. I can fix that
by enforcing tools' compilation in that macro... I'll do that.
bq. Steve, will you double check again if everything works

Yes, everything works for me now, thanks!

bq. and commit this in?

Is there some reason why you can't do this?  IMO committers should commit their own work.

bq. I didn't put an entry into CHANGES so you'd have to add it if it qualifies at all to be
mentioned there.

IMO this definitely warrants a CHANGES.txt entry.

This should also be backported to branch_3x.

bq. This reminds me of the "infrastructure tools" problem we had in Carrot2. We finally decided
to simply have them as a stand-alone project living within the same repository space, with
a stored, versioned binary artefact updated when tools had to be updated (rarely). This does
version a binary file but you don't need to worry about recompiling things over and over.

+1 to do this for this and any other Lucene/Solr Ant tasks.
                
> check-legal isn't doing its job
> -------------------------------
>
>                 Key: LUCENE-3774
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3774
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.6, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>         Attachments: LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch,
LUCENE-3774.patch, LUCENE-3774.patch, LUCENE3774.patch
>
>
> In trunk, the {{check-legal-lucene}} ant target is not checking any {{lucene/contrib/\*\*/lib/}}
directories; the {{modules/**/lib/}} directories are not being checked; and {{check-legal-solr}}
can't be checking {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files
in there that don't have a license.
> These targets are set up to take in a full list of {{lib/}} directories in which to check,
but modules move around, and these lists are not being kept up-to-date.
> Instead, {{check-legal-\*}} should run for each module, if the module has a {{lib/}}
directory, and it should be specialized for modules that have more than one ({{solr/core/}})
or that have a {{lib/}} directory in a non-standard place ({{lucene/core/}}).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message