lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2667) Finish Solr Admin UI
Date Thu, 23 Feb 2012 20:02:50 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214994#comment-13214994
] 

David Smiley commented on SOLR-2667:
------------------------------------

Much better Stefan.  I'd like to see further refactorings:
* I see that the code is using 4-space indentation levels whereas Lucene's standard is 2.
* Although the code is now broken down into logically organized files, there are rather extreme
levels of indentation that makes the code hard to read.  cloud.js goes 14 indentation levels
deep, for example.  That is simply too many, see if you can keep it within 10 at most.

r.js would be nice but I think it's low priority given this is an admin UI.
                
> Finish Solr Admin UI
> --------------------
>
>                 Key: SOLR-2667
>                 URL: https://issues.apache.org/jira/browse/SOLR-2667
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>             Fix For: 4.0
>
>         Attachments: SOLR-2667-110722.patch, SOLR-2667-120223-ant-target.patch, SOLR-2667-120223-file-structure.patch
>
>
> In SOLR-2399, we added a new admin UI. The issue has gotten too long to follow, so this
is a new issue to track remaining tasks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message