lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dodsworth (Commented) (JIRA)" <>
Subject [jira] [Commented] (SOLR-3017) Allow edismax stopword filter factory implementation to be specified
Date Fri, 03 Feb 2012 20:19:53 GMT


Michael Dodsworth commented on SOLR-3017:

Cheers Erick.

Regarding the null check, would it be better to throw an IllegalArgumentException if null
is passed through? Either way, it might be a good idea to javadoc the behaviour when null
is passed.
> Allow edismax stopword filter factory implementation to be specified
> --------------------------------------------------------------------
>                 Key: SOLR-3017
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Michael Dodsworth
>            Priority: Minor
>             Fix For: 4.0
>         Attachments: SOLR-3017-without-guava-alternative.patch, SOLR-3017.patch, SOLR-3017.patch,
> Currently, the edismax query parser assumes that stopword filtering is being done by
StopFilter: the removal of the stop filter is performed by looking for an instance of 'StopFilterFactory'
(hard-coded) within the associated field's analysis chain.
> We'd like to be able to use our own stop filters whilst keeping the edismax stopword
removal goodness. The supplied patch allows the stopword filter factory class to be supplied
as a param, "stopwordFilterClassName". If no value is given, the default (StopFilterFactory)
is used.
> Another option I looked into was to extend StopFilterFactory to create our own filter.
Unfortunately, StopFilterFactory's 'create' method returns StopFilter, not TokenStream. StopFilter
is also final.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message