lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3829) Lucene40 codec's DocValues DirectSource impls aren't thread-safe
Date Tue, 28 Feb 2012 19:57:46 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218542#comment-13218542
] 

Simon Willnauer commented on LUCENE-3829:
-----------------------------------------

wait, I think your test is wrong. DV consumer should pull a source directly from DV per thread.
An instance is not threadsafe per-se. if you pull an "in-memory" source you can simply share
it but the interface doesn't guarantee this. you can simply pull the "in-memory" source in
each thread and you get the same instance since it is cached. The same is true for the on-disk
source since it is not cached. I clone the IndexInput in getDirectSource() to prevent this
problem. 
                
> Lucene40 codec's DocValues DirectSource impls aren't thread-safe
> ----------------------------------------------------------------
>
>                 Key: LUCENE-3829
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3829
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-3829.patch
>
>
> Our DirectSource impls hold IndexInput(s) open against the dat/idx
> files, which we then seek + read when loading a specific document's
> value.  But this is in no way protected against multiple threads
> I think...?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message