lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-3735) Fix PayloadProcessorProvider to no longer use Directory for lookup, instead AtomicReader
Date Wed, 01 Feb 2012 11:02:58 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-3735:
----------------------------------

    Description: 
The PayloadProcessorProvider has a broken API, this should be fixed. The current trunk mimics
the old behaviour, but not 100%.

The PayloadProcessorProvider API should return a PayloadProcessor based on the AtomicReader
instance that gets merged. As AtomicReader do no longer know the directory they are reside
(they could be e.g. FilterIndexReaders, MemoryIndexes,...) a selection by Directory is no
longer possible.

The current code in Lucene trunk mimics the old behavior by doing an instanceof SegmentReader
check and then asking for a DirProvider. If something else is merged in, Payload processing
is not supported. This should be changed, the old API could be kept backwards compatible by
moving the instanceof check in a "convenience class" DirPayloadProcessorProvider, extending
PayloadProcessorProvider.

  was:
The PayloadProcessorProvider has a broken API, this should be fixed. The current patch mimics
the old behaviour, but not 100%.

The PayloadProcessorProvider API should return a PayloadProcessor based on the AtomicReader
instance that gets merged. As AtomicReader do no longer know the directory they are reside
(they could be e.g. FilterIndexReaders, MemoryIndexes,...) a selection by Directory is no
longer possible.

The current code in Lucene trunk mimics the old behavior by doing an instanceof SegmentReader
check and then asking for a DirProvider. If something else is merged in, Payload processing
is not supported. This should be changed, the old API could be kept backwards compatible by
moving the instanceof check in a "convenience class" DirPayloadProcessorProvider, extending
PayloadProcessorProvider.

    
> Fix PayloadProcessorProvider to no longer use Directory for lookup, instead AtomicReader
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3735
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3735
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/index
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3735.patch, LUCENE-3735.patch
>
>
> The PayloadProcessorProvider has a broken API, this should be fixed. The current trunk
mimics the old behaviour, but not 100%.
> The PayloadProcessorProvider API should return a PayloadProcessor based on the AtomicReader
instance that gets merged. As AtomicReader do no longer know the directory they are reside
(they could be e.g. FilterIndexReaders, MemoryIndexes,...) a selection by Directory is no
longer possible.
> The current code in Lucene trunk mimics the old behavior by doing an instanceof SegmentReader
check and then asking for a DirProvider. If something else is merged in, Payload processing
is not supported. This should be changed, the old API could be kept backwards compatible by
moving the instanceof check in a "convenience class" DirPayloadProcessorProvider, extending
PayloadProcessorProvider.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message