lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3807) Cleanup suggester API
Date Tue, 21 Feb 2012 12:40:34 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212551#comment-13212551
] 

Robert Muir commented on LUCENE-3807:
-------------------------------------

I agree with removing IOException from getComparator.

I agree also with moving weight to a long... though currently the e.g. solr integrations take
floats as input,
so this really needs to be listed as a backwards break since it will directly affect users.

I agree with removing the sorted marker interface: its not useful since you don't know the
order.

However, I don't think we should add the charsref methods... I think Bytes/Ints/CharsRef should
have parallel 
apis and someone can just call unicodeutil: in general these are reference classes not stringbuffers
and 
we shouldn't encourage abuse via sugar apis. I already have an issue open for fixing, cleaning
up,
and making those APIs consistent.

I don't think we should add a generics parameter V to Lookup, especially if LookupResult itself
is still
wired to float. I do think suggesters should be able to return additional data but this needs
more thought:
its necessary to actually get the additional data to them.
                
> Cleanup suggester API
> ---------------------
>
>                 Key: LUCENE-3807
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3807
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/other
>    Affects Versions: 3.6, 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-3807.patch, LUCENE-3807.patch
>
>
> Currently the suggester api and especially TermFreqIterator don't play that nice with
BytesRef and other paradigms we use in lucene, further the java iterator pattern isn't that
useful when it gets to work with TermsEnum, BytesRef etc. We should try to clean up this api
step by step moving over to BytesRef including the Lookup class and its interface...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message