lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3141) Deprecate OPTIMIZE command in Solr
Date Sun, 19 Feb 2012 18:58:40 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211480#comment-13211480
] 

Robert Muir commented on SOLR-3141:
-----------------------------------

{quote}
I'm coming around on this issue myself though. For the benefits, optimize is not a good name.
It calls out to be called. The abuse is clearly there, and we should probably try more to
address it than just doc.

My opinion is coming around to leave it for 3.x, change it to an expert option for 4 that
works the same, is understated, and is called forceMerge or whatever.
{quote}

I think we can probably make improvements here, here are my ideas:
# any 'auto-optimization' in our own code is really bad. We should fix any auto/default 
optimizes so that if users want to optimize, they must specify it.
# any 'auto-optimization' in third-party integrations is equally bad, but we can fix this

in a number of ways. Sure, making optimize a no-op is one solution, another is to
actually fix the docs, ping those projects with an email or offer patches, etc.
# we can improve the docs to really emphasize to users how expensive manual
optimize and expungeDeletes calls are. Personally I feel the wiki text Yonik linked to
is way too nice about this.
# the name 'optimize' will always be a trap I think. Can't we start by adding 'forceMerge'
and issue a deprecation warning if someone uses optimize (but still doing it anyway). Then

the next step would be (in some future release), to return a hard error if someone uses
'optimize', since eventually it gets removed.

                
> Deprecate OPTIMIZE command in Solr
> ----------------------------------
>
>                 Key: SOLR-3141
>                 URL: https://issues.apache.org/jira/browse/SOLR-3141
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 3.5
>            Reporter: Jan H√łydahl
>              Labels: force, optimize
>             Fix For: 3.6
>
>
> Background: LUCENE-3454 renames optimize() as forceMerge(). Please read that issue first.
> Now that optimize() is rarely necessary anymore, and renamed in Lucene APIs, what should
be done with Solr's ancient optimize command?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message