lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3743) LuceneTestCase's uncaught exceptions handler should check for AssumptionViolatedExceptions and then not trigger test failure
Date Wed, 01 Feb 2012 00:38:57 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197435#comment-13197435
] 

Robert Muir commented on LUCENE-3743:
-------------------------------------

I really think this is the best solution for this U+FFFF issue, the problems:
1. its only on 3.x becuase the indexer will replace it with U+FFFD (does not happen in trunk)
2. there is likely no bug in an random generator, instead its generating escaped &#FFFF;,
the assert happens at 'tokenizer' level (after charfilters processing)
3. trying to stop generators from generating strings like that is hard, especially since we
test this htmlstripfilter 'chained' with MockCharFilter. for example MockCharFilter doubles
characters 'randomly', and we test HtmlStrip *with* MockCharFilter too (a charfilter chain),
so a random generator could make &#FF;, then MockCharFilter doubles the F's into &#FFFF;,
then HtmlStrip turns it into FFFF.

for these reasons assume is the best, I added this as 'assert' originally because otherwise
its hard to track down why some random searching test fails. if the generators were really
generating
this character tests would be failing left and right.

I dont think they are, I think its the situation described in 2 and 3 above. This is ridiculous
to
spend a lot of time on, when we dont care to assert that this isn't happening, we just want
to
not waste time on scary test failures.
                
> LuceneTestCase's uncaught exceptions handler should check for AssumptionViolatedExceptions
and then not trigger test failure
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3743
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3743
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: general/test
>    Affects Versions: 3.5, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>            Priority: Minor
>         Attachments: LUCENE-3743.patch
>
>
> As in single-threaded tests, {{LuceneTestCase}} should not trigger test failures for
{{AssumptionViolatedException}}'s when they occur in multi-threaded tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message