lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (Commented) (JIRA)" <>
Subject [jira] [Commented] (LUCENE-3774) check-legal isn't doing its job
Date Sun, 12 Feb 2012 18:22:59 GMT


Dawid Weiss commented on LUCENE-3774:

bq. because lucene/ must be buildable/packagable by itself

Does this apply to solr as well? I don't see how this can work with shared tools (like DependencyChecker
previously). If it's so important to have separate build files and separate infrastructure
for solr and lucene then I don't see the point of having the global build file, really.

bq. I see things like ".." from lucene/, I know this cannot totally work,

Where did you see it? If you mean target named "_test_" then this is only for debugging, I
should have removed it.
> check-legal isn't doing its job
> -------------------------------
>                 Key: LUCENE-3774
>                 URL:
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.6, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>         Attachments: LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch
> In trunk, the {{check-legal-lucene}} ant target is not checking any {{lucene/contrib/\*\*/lib/}}
directories; the {{modules/**/lib/}} directories are not being checked; and {{check-legal-solr}}
can't be checking {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files
in there that don't have a license.
> These targets are set up to take in a full list of {{lib/}} directories in which to check,
but modules move around, and these lists are not being kept up-to-date.
> Instead, {{check-legal-\*}} should run for each module, if the module has a {{lib/}}
directory, and it should be specialized for modules that have more than one ({{solr/core/}})
or that have a {{lib/}} directory in a non-standard place ({{lucene/core/}}).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message