lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (LUCENE-3753) Restructure the Lucene build system
Date Sat, 11 Feb 2012 09:28:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206065#comment-13206065
] 

Uwe Schindler edited comment on LUCENE-3753 at 2/11/12 9:27 AM:
----------------------------------------------------------------

Steven: There is still a problem with the clover reports: The directories for generating the
reports don't correctly identify "Tests", "Test Results" and the "Class files". The ant task's
"generate-clover-reports" seems to use the wrong paths. It looks like it only catches some
tests, most test classes are listed under

We need maybe a more "universal" fileset for <testsources/> and <testresults/>.
Maybe use the first one for contrib somehow globally:

{code:xml}
<fileset dir="contrib" id="clover.contrib.test.src.files">
 <include name="**/test/**/*.java"/>
</fileset>
{code}

(e.g. using dir="."). Same for test-results, this is also wrong:

{code:xml}
<fileset dir="${build.dir}" id="clover.test.result.files">
 <include name="**/test/TEST-*.xml" />
 <!-- do not include BW tests -->
 <exclude name="backwards/**"/>
</fileset>
{code}

Affects both 3.x and trunk. I don't want to fix it, you know better *where* al those different
build dirs could live.

Ah, here are the reports: https://builds.apache.org/job/Lucene-trunk/clover/ (you can see
the bugs when you look on the left frame and switch between the tabs "Classes", "Tests", "Results".
Most tests are now listed at "Classes", which is wrong.
                
      was (Author: thetaphi):
    Steven: There is still a problem with the clover reports: The directories for generating
the reports don't correctly identify "Tests", "Test Results" and the "Class files". The ant
task's "generate-clover-reports" seems to use the wrong paths. It looks like it only catches
some tests, most test classes are listed under

We need maybe a more "universal" fileset for <testsources/> and <testresults/>.
Maybe use the first one for contrib somehow globally:

{code:xml}
<fileset dir="contrib" id="clover.contrib.test.src.files">
 <include name="**/test/**/*.java"/>
</fileset>
{code}

(e.g. using dir="."). Same for test-results, this is also wrong:

{code:xml}
<fileset dir="${build.dir}" id="clover.test.result.files">
 <include name="**/test/TEST-*.xml" />
 <!-- do not include BW tests -->
 <exclude name="backwards/**"/>
</fileset>
{code}

Affects both 3.x and trunk. I don't want to fix it, you know better *where* al those different
build dirs could live.
                  
> Restructure the Lucene build system
> -----------------------------------
>
>                 Key: LUCENE-3753
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3753
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.6, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3753.patch, LUCENE-3753.patch, LUCENE-3753.patch
>
>
> Split out separate core/, test-framework/, and tools/ modules, each with its own build.xml,
under the lucene/ directory, similar to the Solr restructuring done in SOLR-2452.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message