lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (LUCENE-3794) DirectoryTaxonomyWriter can lose the INDEX_CREATE_TIME property, causing DirTaxoReader.refresh() to falsely succeed (or fail)
Date Thu, 16 Feb 2012 12:57:59 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-3794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shai Erera resolved LUCENE-3794.
--------------------------------

    Resolution: Fixed

Committed revision 1244960 (3x).
Committed revision 1244964 (trunk).
                
> DirectoryTaxonomyWriter can lose the INDEX_CREATE_TIME property, causing DirTaxoReader.refresh()
to falsely succeed (or fail)
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3794
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3794
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: modules/facet
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3794.patch
>
>
> DirTaxoWriter sets createTime to null after it put it in the commit data once. But that's
wrong because if one calls commit(Map<>) twice, the second time doesn't record the creation
time. Also, in the ctor, if an index exists and OpenMode is not CREATE, the creation time
property is not read.
> I wrote a couple of unit tests that assert this, and modified DirTaxoWriter to always
record the creation time (in every commit) -- that's the only safe way.
> Will upload a patch shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message