lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2802) Toolkit of UpdateProcessors for modifying document values
Date Thu, 09 Feb 2012 21:32:57 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204896#comment-13204896
] 

Robert Muir commented on SOLR-2802:
-----------------------------------

I think the min/max is strange: it catches ClassCastException (as hoss explained on dev list):
{noformat}
 * If this is not the case, then the full list of all values found will be 
 * used as is.
{noformat}

In my opinion, I think if a user asks for min or max or some other computation, and this is
not possible,
it should return an error? otherwise why did they configure this in their chain? 

I don't think its friendly to just sneakily act as a no-op instead...

Moreover, the root cause of the eclipse-compiler problems I think is because its not taking
Comparable?
I think min/max should not extend this type-unsafe Subset base, as they should not return
a subset anyway, 
but a singleton, and the input must be comparable... 
                
> Toolkit of UpdateProcessors for modifying document values
> ---------------------------------------------------------
>
>                 Key: SOLR-2802
>                 URL: https://issues.apache.org/jira/browse/SOLR-2802
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 4.0
>
>         Attachments: SOLR-2802_update_processor_toolkit.patch, SOLR-2802_update_processor_toolkit.patch,
SOLR-2802_update_processor_toolkit.patch, SOLR-2802_update_processor_toolkit.patch, SOLR-2802_update_processor_toolkit.patch
>
>
> Frequently users ask about questions about things where the answer is "you could do it
with an UpdateProcessor" but the number of our of hte box UpdateProcessors is generally lacking
and there aren't even very good base classes for the common case of manipulating field values
when adding documents

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message