lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3157) custom logging
Date Tue, 28 Feb 2012 17:53:52 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218398#comment-13218398
] 

Hoss Man commented on SOLR-3157:
--------------------------------

Yonik: your changes in r1294212 break the SolrCore.execute log format conventions we've had
in place since SOLR-267, which breaks some log processing code i have (and since the whole
point of SOLR-267 was to make it easy for people to write log parses, i'm guessing i'm not
the only one)

Notably:
 * you changed the "path" and "params" key=val pairs so they no longer include the key, just
the val -- this doesn't really make sense to me since the whole point of those log lines is
that they are suppose to be consistent and easy to parse.
 * you removed the webapp key=val pair completely (comment says "multiple webaps are no longer
best practise" but that doesn't mean people don't use them or that we should just suddenly
stop logging them.
                
> custom logging
> --------------
>
>                 Key: SOLR-3157
>                 URL: https://issues.apache.org/jira/browse/SOLR-3157
>             Project: Solr
>          Issue Type: Test
>            Reporter: Yonik Seeley
>            Priority: Blocker
>         Attachments: SOLR-3157.patch, jetty_threadgroup.patch
>
>
> We need custom logging to decipher tests with multiple core containers, cores, in a single
JVM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message