lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-3832) Port BasicAutomata.stringUnion from Brics to Lucene
Date Wed, 29 Feb 2012 13:45:56 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219201#comment-13219201
] 

Michael McCandless commented on LUCENE-3832:
--------------------------------------------

bq. We should then just move Robert's port instead of what I pulled from Brics.

+1, as long as we can reconcile that the diffs are not "meaningful" :)  Maybe you fixed a
bug since we added this to Lucene!

EG a small diff is your version does the .sort() for the caller, but Lucene's version requires
caller do the .sort()...
                
> Port BasicAutomata.stringUnion from Brics to Lucene
> ---------------------------------------------------
>
>                 Key: LUCENE-3832
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3832
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Trivial
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3832.patch
>
>
> Brics has my code to build Automaton from a set of sorted strings in one step (Daciuk/Mihov's
algorithm again). This should be easily portable to Lucene and is quite useful.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message