lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2368) Improve extended dismax (edismax) parser
Date Wed, 29 Feb 2012 02:25:57 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218845#comment-13218845
] 

Hoss Man commented on SOLR-2368:
--------------------------------

bq. Are you saying it would be possible to define something like this in solrconfig.xml

...something like that would certainly be possible if we changed the QParsers to start doing
interesting things with their init params (presumably defaults there would be the lowest possible
level defaults, overridden by things like request handler defaults/invariants/appends ...
and it would really make sense to allow invariants/appends in the qparser init).

but that would only really help with the backcompat "locked down" dismax situation i'm concerned
with if we made sure all of those init params were also used in the implicitly created instance
of "dismax"

what i had in mind was actually far simpler...

* "dismax" is implicitly an instance of DismaxQParserPlugin (unless overridden in solrconfig.xml)
.. just like today
* "edismax" is implicitly an instance of ExtendedDismaxQParserPlugin (unless overridden in
solrconfig.xml) ... just like today
* ExtendedDismaxQParserPlugin works exactly as it does today but instead of all the hardcoded
default param values sprinkled around ExtendedDismaxQParser we put them all in a static Map
or SolrParams instance and add a constructor arg to override those defaults
* DismaxQParserPlugin gets changed to look something like...
{code}
final static SolrParams REALLY_LIMITED_DEFAULTS = new SolrParams("uf", "-*", ...);
public QParser createParser(String qstr, SolrParams localParams, SolrParams params, SolrQueryRequest
req) {
  return new ExtendedDisMaxQParser(qstr, localParams, params, req, REALLY_LIMITED_DEFAULTS);
}
{code}
...using that new ExtendedDisMaxQParser constructor arg to override the defaults * DisMaxQParser.java
gets svn removed because it's no longer needed.

...all of which could then be enhanced with init based overrides of those defaults like you
suggested.
                
> Improve extended dismax (edismax) parser
> ----------------------------------------
>
>                 Key: SOLR-2368
>                 URL: https://issues.apache.org/jira/browse/SOLR-2368
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: Yonik Seeley
>              Labels: QueryParser
>
> This is a "mother" issue to track further improvements for eDismax parser.
> The goal is to be able to deprecate and remove the old dismax once edismax satisfies
all usecases of dismax.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message