lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-3040) Avoid use of qt param for the DIH in the admin UI
Date Thu, 23 Feb 2012 13:21:48 GMT

    [ https://issues.apache.org/jira/browse/SOLR-3040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214619#comment-13214619
] 

David Smiley commented on SOLR-3040:
------------------------------------

Thanks for reminding me to add a CHANGES entry because I definitely should.  I plan on doing
this on both branches because I think it would be both unlikely and a bad idea for someone
to not have a leading slash on their DIH handler, and it's trivial for them to fix, and if
they insist on not fixing it then this piece of the admin UI won't work which is hardly the
end of the world -- it's just an html page.

The rest of your comment pertains to SOLR-1233 which as you surmised is what I'll be doing
next.  Lets discuss that issue there, not here.
                
> Avoid use of qt param for the DIH in the admin UI
> -------------------------------------------------
>
>                 Key: SOLR-3040
>                 URL: https://issues.apache.org/jira/browse/SOLR-3040
>             Project: Solr
>          Issue Type: Improvement
>          Components: web gui
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: SOLR-3040_avoid_qt_for_DIH_in_admin_ui.patch
>
>
> I really, really dislike that the qt parameter can used to refer to request handlers
starting with a '/', _especially_ for non-search handlers.  The admin UI has one place I am
aware of that attempts to do this, which is the DIH's admin page.  Since we have two UIs in
trunk, the new and old, there are actually two UIs where this occurs, and the old UI has two
related files that need updating, in order to address this issue.
> An example URL generated by the UI today is this:
>   http://localhost:8983/solr/rss/select?qt=/dataimport&command=show-config
> And here it is without using qt:
>   http://localhost:8983/solr/rss/dataimport?command=show-config
> I do realize that fixing this issue as I do in my patch will make the UI not work if
the DIH isn't registered with a leading '/', but honestly I wonder who if anyone out there
does that.  And even then, it's easily rectified.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message