lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LUCENE-3777) trapping overloaded ctors/setters in Field/NumericField/DocValuesField
Date Tue, 14 Feb 2012 03:46:59 GMT
trapping overloaded ctors/setters in Field/NumericField/DocValuesField
----------------------------------------------------------------------

                 Key: LUCENE-3777
                 URL: https://issues.apache.org/jira/browse/LUCENE-3777
             Project: Lucene - Java
          Issue Type: Bug
    Affects Versions: 4.0
            Reporter: Robert Muir


In trunk, these apis let you easily create a field, but my concern is this:
{code}
public NumericField(String name, int value)
public NumericField(String name, long value)
..
public Field(String name, int value, FieldType type)
public Field(String name, long value, FieldType type)
..
public void setValue(int value)
public void setValue(long value)
..
public DocValuesField(String name, int value, DocValues.Type docValueType)
public DocValuesField(String name, long value, DocValues.Type docValueType)
{code}

I really don't like overloaded ctors/setters where the compiler can type-promote you,
I think it makes the apis hard to use.

Instead for the setters I think we sohuld have setIntValue, setLongValue, ...
For the ctors, I see two other options:
# factories like DocValuesField.newIntField()
# subclasses like IntField

I don't have any patch for this, but I think we should discuss and fix before these apis are
released.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message