lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (Issue Comment Edited) (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Edited] (LUCENE-3760) Cleanup DR.getCurrentVersion/DR.getUserData/DR.getIndexCommit().getUserData()
Date Wed, 15 Feb 2012 09:06:01 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208283#comment-13208283
] 

Uwe Schindler edited comment on LUCENE-3760 at 2/15/12 9:04 AM:
----------------------------------------------------------------

By the way: Why is the return value of listCommits() Collection<IndexCommit> and not
List<IndexCommit>. There is only one implementation, that already uses a List, so for
things like getting newest Commit quickly, it might be better to have a List or SortedSet.

Change is easy (maybe in separate issue). In 4.0 we should change this (3.x is also possible
because of backwards using return type overloading).
                
      was (Author: thetaphi):
    By the way: Why is the return value of listCommits() Collection<IndexCommit> and
not List<IndexCommit>. There is only one implementation, that already uses a List, so
for things like getting newest Commit quickly, it might be better to have a List or SortedSet.

Change is easy (maybe in separate issue).
                  
> Cleanup DR.getCurrentVersion/DR.getUserData/DR.getIndexCommit().getUserData()
> -----------------------------------------------------------------------------
>
>                 Key: LUCENE-3760
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3760
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3760.patch, LUCENE-3760.patch
>
>
> Spinoff from Ryan's dev thread "DR.getCommitUserData() vs DR.getIndexCommit().getUserData()"...
these methods are confusing/dups right now.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message