lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangtai Liang (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (LUCENE-3779) An incomplete fix for the NPE bugs in MultipleTermPositions.java
Date Tue, 14 Feb 2012 12:38:59 GMT
An incomplete fix for the NPE bugs in MultipleTermPositions.java
----------------------------------------------------------------

                 Key: LUCENE-3779
                 URL: https://issues.apache.org/jira/browse/LUCENE-3779
             Project: Lucene - Java
          Issue Type: Bug
          Components: core/index
    Affects Versions: 3.0
            Reporter: Guangtai Liang
            Priority: Critical


The fix revision 219387 was aimed to remove an NPE bug on the  return value of  "_termPositionsQueue.peek()"
in the method "skipTo" of the file "/lucene/java/trunk/src/java/org/apache/lucene/index/MultipleTermPositions.java"
, but it is incomplete. 
Since the returned value  "_termPositionsQueue.peek()" could be null during the run-time execution,
its value should also be null-checked before being dereferenced in other methods. 

The buggy code locations the same fix needs to be applied at are as bellows: 
 
Line 118, 124, 135 of the method "next()" : 

public final boolean next() throws IOException {
    if (_termPositionsQueue.size() == 0)
      return false;

    _posList.clear();
[Line  118]    _doc = _termPositionsQueue.peek().doc();

    TermPositions tp;
    do {
      tp = _termPositionsQueue.peek();

[Line  124]        for (int i = 0; i < tp.freq(); i++) {
          // NOTE: this can result in dup positions being added!
        _posList.add(tp.nextPosition());
        }

      if (tp.next())
        _termPositionsQueue.updateTop();
      else {
        _termPositionsQueue.pop();
        tp.close();
      }
[Line  135]    } while (_termPositionsQueue.size() > 0 && _termPositionsQueue.peek().doc()
== _doc);

    _posList.sort();
    _freq = _posList.size();

    return true;

  }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message