lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-2632) FilteringCodec, TeeCodec, TeeDirectory
Date Tue, 14 Feb 2012 12:49:00 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207679#comment-13207679
] 

Robert Muir commented on LUCENE-2632:
-------------------------------------

just some ideas taking a very quick glance

* I like the idea of separate impl packages you used here...
* the TODO/etc in term vectors makes me wish our codec consumer APIs for Fields/TermVectors
were more consistent...
* lots of methods have 'synchronized' where I think its not needed? e.g. TeeTermVectorsWriter
* close() in Tee* should probably add all closeables to a list and then IOUtils.close() that.
* TeeCodec.files() i think should call mainCodec.files, so that it doesn't rely upon mainCodec
having the default implementation in Codec.java (some dont).

Sorry, none of this fixes the merging test, which i think is somehow related to files(), but
I didn't spot the bug yet at a glance.


                
> FilteringCodec, TeeCodec, TeeDirectory
> --------------------------------------
>
>                 Key: LUCENE-2632
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2632
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Andrzej Bialecki 
>         Attachments: LUCENE-2632.patch, LUCENE-2632.patch
>
>
> This issue adds two new Codec implementations:
> * TeeCodec: there have been attempts in the past to implement parallel writing to multiple
indexes so that they are all synchronized. This was however complicated due to the complexity
of IndexWriter/SegmentMerger logic. The solution presented here offers a similar functionality
but working on a different level - as the name suggests, the TeeCodec duplicates index data
into multiple output Directories.
> * TeeDirectory (used also in TeeCodec) is a simple abstraction to perform Directory operations
on several directories in parallel (effectively mirroring their data). Optionally it's possible
to specify a set of suffixes of files that should be mirrored so that non-matching files are
skipped.
> * FilteringCodec is related in a remote way to the ideas of index pruning presented in
LUCENE-1812 and the concept of tiered search. Since we can use TeeCodec to write to multiple
output Directories in a synchronized way, we could also filter out or modify some of the data
that is being written. The FilteringCodec provides this functionality, so that you can use
like this:
> {code}
> IndexWriter --> TeeCodec
>                  |  |
>                  |  +--> StandardCodec --> Directory1
>                  +--> FilteringCodec --> StandardCodec --> Directory2
> {code}
> The end result of this chain is two indexes that are kept in sync - one is the full regular
index, and the other one is a filtered index.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message