lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler" <...@thetaphi.de>
Subject RE: [JENKINS] Lucene-trunk - Build # 1835 - Failure
Date Tue, 21 Feb 2012 10:10:16 GMT
I am fine with the ParallelAtomic patch, only populate fieldsToReader for all fields, as its
also used for docvalues (and term vectors, but those are only valid for indexed fields).

Uwe

-----
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: uwe@thetaphi.de


> -----Original Message-----
> From: Robert Muir [mailto:rcmuir@gmail.com]
> Sent: Tuesday, February 21, 2012 10:50 AM
> To: dev@lucene.apache.org
> Subject: Re: [JENKINS] Lucene-trunk - Build # 1835 - Failure
> 
> Both ParallelAtomicReader and this test are buggy in my opinion :)
> 
> On one hand, the test should realize that fieldsEnum might return fields where
> terms is null (FieldsEnum documents this!)
> 
> On the other hand, ParallelAtomicReader shouldn't add non-indexed fields into
> its map, because thats wasteful:
> 
> Index: src/java/org/apache/lucene/index/ParallelAtomicReader.java
> ================================================================
> ===
> --- src/java/org/apache/lucene/index/ParallelAtomicReader.java
> 	(revision
> 1291672)
> +++ src/java/org/apache/lucene/index/ParallelAtomicReader.java
> 	(working copy)
> @@ -105,8 +105,10 @@
>          // NOTE: first reader having a given field "wins":
>          if (!fieldToReader.containsKey(fieldInfo.name)) {
>            fieldInfos.add(fieldInfo);
> -          fieldToReader.put(fieldInfo.name, reader);
> -          this.fields.addField(fieldInfo.name, reader.terms(fieldInfo.name));
> +          if (fieldInfo.isIndexed) {
> +            fieldToReader.put(fieldInfo.name, reader);
> +            this.fields.addField(fieldInfo.name, reader.terms(fieldInfo.name));
> +          }
>          }
>        }
>      }
> 
> 
> 
> On Mon, Feb 20, 2012 at 11:30 PM, Apache Jenkins Server
> <jenkins@builds.apache.org> wrote:
> > Build: https://builds.apache.org/job/Lucene-trunk/1835/
> >
> > 1 tests failed.
> > REGRESSION:
> > org.apache.lucene.search.TestTermVectors.testKnownSetOfDocuments
> >
> > Error Message:
> > null
> >
> > Stack Trace:
> > junit.framework.AssertionFailedError
> >        at
> > org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRun
> > ner.java:165)
> >        at
> > org.apache.lucene.util.LuceneTestCaseRunner.runChild(LuceneTestCaseRun
> > ner.java:57)
> >        at
> > org.apache.lucene.search.TestTermVectors.testKnownSetOfDocuments(TestT
> > ermVectors.java:259)
> >        at
> > org.apache.lucene.util.LuceneTestCase$SubclassSetupTeardownRule$1.eval
> > uate(LuceneTestCase.java:705)
> >        at
> > org.apache.lucene.util.LuceneTestCase$InternalSetupTeardownRule$1.eval
> > uate(LuceneTestCase.java:604)
> >        at
> > org.apache.lucene.util.LuceneTestCase$TestResultInterceptorRule$1.eval
> > uate(LuceneTestCase.java:509)
> >        at
> > org.apache.lucene.util.LuceneTestCase$RememberThreadRule$1.evaluate(Lu
> > ceneTestCase.java:567)
> >
> >
> >
> >
> > Build Log (for compile errors):
> > [...truncated 13502 lines...]
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For
> > additional commands, e-mail: dev-help@lucene.apache.org
> 
> 
> 
> --
> lucidimagination.com
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional
> commands, e-mail: dev-help@lucene.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message