Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A5BABE59 for ; Mon, 16 Jan 2012 07:10:34 +0000 (UTC) Received: (qmail 577 invoked by uid 500); 16 Jan 2012 07:10:30 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 99638 invoked by uid 500); 16 Jan 2012 07:10:10 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 99586 invoked by uid 99); 16 Jan 2012 07:10:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jan 2012 07:10:03 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jan 2012 07:10:01 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 1BAF114FA71 for ; Mon, 16 Jan 2012 07:09:40 +0000 (UTC) Date: Mon, 16 Jan 2012 07:09:40 +0000 (UTC) From: "Koji Sekiguchi (Commented) (JIRA)" To: dev@lucene.apache.org Message-ID: <788761443.43805.1326697780134.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1531082370.43003.1326654939592.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LUCENE-3697) FastVectorHighlighter SimpleBoundaryScanner does not work well when highlighting at the beginning of the text MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186740#comment-13186740 ] Koji Sekiguchi commented on LUCENE-3697: ---------------------------------------- Patch makes sense. bq. This causes the SimpleFragmentsBuilderTest#testMVSeparator to fail, because it has empty string fields which are separated by a custom separator. Yes. I think that just fixing the expected string in #testMVSeparator is fine. > FastVectorHighlighter SimpleBoundaryScanner does not work well when highlighting at the beginning of the text > -------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-3697 > URL: https://issues.apache.org/jira/browse/LUCENE-3697 > Project: Lucene - Java > Issue Type: Bug > Components: modules/highlighter > Reporter: Shay Banon > Attachments: LUCENE-3697.patch > > > The SimpleBoundaryScanner still breaks text not based on characters provided when highlighting text that end up scanning to the beginning of the text to highlight. In this case, just use the start of the text as the offset. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org