Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Tue, 13 Dec 2011 19:24:30 +0000 (UTC)
From: "Michael McCandless (Reopened) (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <669578910.6860.1323804270646.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1730840950.12991.1319545113180.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Reopened] (LUCENE-3531) Improve CachingWrapperFilter to
 optionally also cache acceptDocs, if identical to liveDocs
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/LUCENE-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless reopened LUCENE-3531:
----------------------------------------


Uwe found a sneaky problem here: using acceptDocs as the cache key is bad, eg FixedBitSet's equals/hashCode are horribly costly... we need a WeakIdentityHashMap.
                
> Improve CachingWrapperFilter to optionally also cache acceptDocs, if identical to liveDocs
> ------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3531
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3531
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-3531.patch
>
>
> Spinoff from LUCENE-1536: This issue removed the different cache modes completely and always applies the acceptDocs using BitsFilteredDocIdSet.wrap(), the cache only contains raw DocIdSet without any deletions/acceptDocs. For IndexReaders that are seldom reopened, this might not be as performant as it could be. If the acceptDocs==IR.liveDocs, those DocIdSet could also be cached with liveDocs applied.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org