Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@lucene.apache.org
Date: Fri, 9 Dec 2011 17:58:41 +0000 (UTC)
From: "Uwe Schindler (Issue Comment Edited) (JIRA)" <jira@apache.org>
To: dev@lucene.apache.org
Message-ID: 
 <1398212761.59211.1323453521574.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1162716926.18386.1322500180276.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Issue Comment Edited] (LUCENE-3606) Make IndexReader really
 read-only in Lucene 4.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LUCENE-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166366#comment-13166366 ] 

Uwe Schindler edited comment on LUCENE-3606 at 12/9/11 5:58 PM:
----------------------------------------------------------------

Merged changes to trunk revision: 1212545

This issue is now finished, thanks to Robert for the great help during fixing tests and funny discussions :-)
*edit* ...and for porting norms to codec! *edit*
                
      was (Author: thetaphi):
    Merged changes to trunk revision: 1212545

This issue is now finished, thanks to Robert for the great help during fixing tests and funny discussions :-)
                  
> Make IndexReader really read-only in Lucene 4.0
> -----------------------------------------------
>
>                 Key: LUCENE-3606
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3606
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 3.6, 4.0
>
>         Attachments: LUCENE-3606-deprecations3x.patch, LUCENE-3606-deprecations3x.patch, LUCENE-3606-deprecations3x.patch, LUCENE-3606-hideMethodAgain.patch, LUCENE-3606.patch
>
>
> As we change API completely in Lucene 4.0 we are also free to remove read-write access and commits from IndexReader. This code is so hairy and buggy (as investigated by Robert and Mike today) when you work on SegmentReader level but forget to flush in the DirectoryReader, so its better to really make IndexReaders readonly.
> Currently with IndexReader you can do things like:
> - delete/undelete Documents -> Can be done by with IndexWriter, too (using deleteByQuery)
> - change norms -> this is a bad idea in general, but when we remove norms at all and replace by DocValues this is obsolete already. Changing DocValues should also be done using IndexWriter in trunk (once it is ready)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org