Return-Path: X-Original-To: apmail-lucene-dev-archive@www.apache.org Delivered-To: apmail-lucene-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 134307B47 for ; Fri, 9 Dec 2011 17:47:04 +0000 (UTC) Received: (qmail 90923 invoked by uid 500); 9 Dec 2011 17:47:03 -0000 Delivered-To: apmail-lucene-dev-archive@lucene.apache.org Received: (qmail 90842 invoked by uid 500); 9 Dec 2011 17:47:03 -0000 Mailing-List: contact dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@lucene.apache.org Delivered-To: mailing list dev@lucene.apache.org Received: (qmail 90835 invoked by uid 99); 9 Dec 2011 17:47:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2011 17:47:03 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2011 17:47:01 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 696A6108F57 for ; Fri, 9 Dec 2011 17:46:40 +0000 (UTC) Date: Fri, 9 Dec 2011 17:46:40 +0000 (UTC) From: "Uwe Schindler (Commented) (JIRA)" To: dev@lucene.apache.org Message-ID: <1280962695.59153.1323452800433.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1162716926.18386.1322500180276.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (LUCENE-3606) Make IndexReader really read-only in Lucene 4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/LUCENE-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166355#comment-13166355 ] Uwe Schindler commented on LUCENE-3606: --------------------------------------- Committed 3.x revision: 1212539 > Make IndexReader really read-only in Lucene 4.0 > ----------------------------------------------- > > Key: LUCENE-3606 > URL: https://issues.apache.org/jira/browse/LUCENE-3606 > Project: Lucene - Java > Issue Type: Task > Components: core/index > Affects Versions: 4.0 > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Fix For: 4.0 > > Attachments: LUCENE-3606-deprecations3x.patch, LUCENE-3606-deprecations3x.patch, LUCENE-3606-deprecations3x.patch, LUCENE-3606-hideMethodAgain.patch, LUCENE-3606.patch > > > As we change API completely in Lucene 4.0 we are also free to remove read-write access and commits from IndexReader. This code is so hairy and buggy (as investigated by Robert and Mike today) when you work on SegmentReader level but forget to flush in the DirectoryReader, so its better to really make IndexReaders readonly. > Currently with IndexReader you can do things like: > - delete/undelete Documents -> Can be done by with IndexWriter, too (using deleteByQuery) > - change norms -> this is a bad idea in general, but when we remove norms at all and replace by DocValues this is obsolete already. Changing DocValues should also be done using IndexWriter in trunk (once it is ready) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org For additional commands, e-mail: dev-help@lucene.apache.org