[ https://issues.apache.org/jira/browse/SOLR-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160607#comment-13160607 ] 

Grant Ingersoll commented on SOLR-1726:
---------------------------------------

Hi Manoj,

This looks OK as a start.  Would be nice to have tests to go with it.  

Why the overriding of getTotalHits on the TopScoreDocCollector?  I don't think returning collectedHits is the right thing to do there.

Also, you should be able to avoid an extra Collector create call at:
{code}
        topCollector = TopScoreDocCollector.create(len, true);
        //Issue 1726 Start
        if(cmd.getScoreDoc() != null)
        {
        	topCollector = TopScoreDocCollector.create(len, cmd.getScoreDoc(), true); //create the Collector with InOrderPagingCollector
        }

{code}

But that is easy enough to fix.


                
> Deep Paging and Large Results Improvements
> ------------------------------------------
>
>                 Key: SOLR-1726
>                 URL: https://issues.apache.org/jira/browse/SOLR-1726
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>         Attachments: CommonParams.java, QParser.java, QueryComponent.java, ResponseBuilder.java, SOLR-1726.patch, SolrIndexSearcher.java, TopDocsCollector.java, TopScoreDocCollector.java
>
>
> There are possibly ways to improve collections of "deep paging" by passing Solr/Lucene more information about the last page of results seen, thereby saving priority queue operations.   See LUCENE-2215.
> There may also be better options for retrieving large numbers of rows at a time that are worth exploring.  LUCENE-2127.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org